Skip to content

Switch to the triggered dagrun on manual trigger.#54336

Merged
pierrejeambrun merged 1 commit intoapache:mainfrom
tirkarthi:gh54189
Aug 12, 2025
Merged

Switch to the triggered dagrun on manual trigger.#54336
pierrejeambrun merged 1 commit intoapache:mainfrom
tirkarthi:gh54189

Conversation

@tirkarthi
Copy link
Contributor

@tirkarthi tirkarthi commented Aug 11, 2025

Whenever a dagrun is triggered manually from UI, switch to the triggered dagrun in graph/grid view similar to Airflow 2.

Closes #54189

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Aug 11, 2025
@tirkarthi tirkarthi requested a review from potiuk August 11, 2025 04:43
@tirkarthi tirkarthi mentioned this pull request Aug 11, 2025
Closed
2 tasks
guan404ming
guan404ming approved these changes Aug 11, 2025
View reviewed changes
Copy link
Member

@guan404ming guan404ming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

jscheffl
jscheffl approved these changes Aug 11, 2025
View reviewed changes
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That really improves in my view.

Should we back-port this to 3.0.x?

I was first worried about that the run_id needs to be URL-encoded... only 99% sure after my testing... should work as it is?

potiuk
potiuk approved these changes Aug 11, 2025
View reviewed changes
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is is SO MUCH BETTER :)

@potiuk
Copy link
Member

potiuk commented Aug 11, 2025

Should we back-port this to 3.0.x?

I would be for it.

@potiuk potiuk added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Aug 11, 2025
@tirkarthi
Copy link
Contributor Author

tirkarthi commented Aug 12, 2025

navigate doesn't seem to encode uri by default. There is configuration to validate run_id by regex through allowed_run_id_pattern. Since the links to dag run in the runs tab and dag_run list page are not encoded I guess it's okay to skip encoding. Encoded urls also work as per my testing.

Current URL :

http://localhost:8000/dags/example_display_name/runs/manual__2025-08-12T03:51:19.882418+00:00

Encoded URL :

http://localhost:8000/dags/example_display_name/runs/manual__2025-08-12T03%3A51%3A19.882418%2B00%3A00

https://github.com/remix-run/react-router/blob/a089339c58ee0758db81b0a9c680b308628dddf7/packages/react-router/lib/hooks.tsx#L362
https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html#allowed-run-id-pattern

@pierrejeambrun pierrejeambrun merged commit 5c8c135 into apache:main Aug 12, 2025
55 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 12, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@jscheffl
Copy link
Contributor

jscheffl commented Aug 12, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Ups, what went wrong here... was not the first PR for him... ?!?!?

@tirkarthi
Copy link
Contributor Author

tirkarthi commented Aug 12, 2025

@jscheffl I am not sure. It didn't create the backport PR too. My guess is that there was a GitHub outage at the time the PR was merged that could have caused this.

https://www.githubstatus.com/incidents/9rfydl2xdqqj

pierrejeambrun pushed a commit to astronomer/airflow that referenced this pull request Aug 18, 2025
@tirkarthi @pierrejeambrun
Switch to the triggered dagrun on manual trigger. (apache#54336)
7bc30e5 
(cherry picked from commit 5c8c135)
@pierrejeambrun
Copy link
Member

pierrejeambrun commented Aug 18, 2025

Manual backport here:
#54616

potiuk pushed a commit that referenced this pull request Aug 18, 2025
@pierrejeambrun @tirkarthi
Switch to the triggered dagrun on manual trigger. (#54336) (#54616)
cd5715d 
(cherry picked from commit 5c8c135)

Co-authored-by: Karthikeyan Singaravelan <tir.karthi@gmail.com>
kaxil pushed a commit that referenced this pull request Aug 18, 2025
@tirkarthi @kaxil
Switch to the triggered dagrun on manual trigger. (#54336)
17d7b60 
(cherry picked from commit 5c8c135)
@kaxil kaxil mentioned this pull request Aug 22, 2025
Closed
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiuk potiuk potiuk approved these changes

@pierrejeambrun pierrejeambrun pierrejeambrun approved these changes

@jscheffl jscheffl jscheffl approved these changes

@guan404ming guan404ming guan404ming approved these changes

@bbovenzi bbovenzi Awaiting requested review from bbovenzi bbovenzi is a code owner

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

@shubhamraj-git shubhamraj-git Awaiting requested review from shubhamraj-git shubhamraj-git is a code owner

Assignees

No one assigned

Labels

area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Switch to triggered task at "graph" view after triggering dag

5 participants

@tirkarthi @potiuk @jscheffl @pierrejeambrun @guan404ming